This repository was archived by the owner on Nov 1, 2023. It is now read-only.
[Bug Fix] Adding Check for SP During User Role Assignment. #1497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreisen
approved these changes
Nov 30, 2021
chkeita
reviewed
Nov 30, 2021
src/deployment/deploy.py
Outdated
| ) | ||
|
|
||
| def assign_user_access(self) -> None: | ||
| if self.results["client_id"]: |
Contributor
There was a problem hiding this comment.
I don't understand this condition
why skipping when the client_id is set ? Shouldn't we update the application backing that client_id instead ?
Contributor
Author
There was a problem hiding this comment.
Are you suggesting we retrieve the underlying application and update it?
Contributor
Author
There was a problem hiding this comment.
Is that done anywhere else? It was my impression that you wouldnt be able to edit any AAD objects with an SP.
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Okay @chkeita, I actually just changed it to self.upgrade. The original logic did not work properly because client_id and client_secret are set regardless.
…nharper285/onefuzz into user/noharper/sp-deploy-bug-fix
chkeita
reviewed
Nov 30, 2021
Co-authored-by: Cheick Keita <kcheick@gmail.com>
chkeita
approved these changes
Nov 30, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
I introduced a bug when I implemented the new function for assigning user access. If a user tried upgrading an instance with an SP, then deployment would fail when this function was called due to lack of permissions.
PR Checklist
Info on Pull Request
What does this include?
Changes to deploy.py assign_user_access()
Validation Steps Performed
check-pr run.
How does someone test & validate?
Deploy with a service principal.