Repository navigation
release: name the mismatched fields in Ubuntu artifact manifest errors - #604
Closed
烜 (xuanshen666) wants to merge 1 commit into
Closed
烜 (xuanshen666) wants to merge 1 commit into
烜 (xuanshen666) wants to merge 1 commit into
Conversation
The Ubuntu artifact manifest check raised the same generic message for any of its five fields, hiding which field differed. Report every mismatched field with the manifest value and the expected value, name the failing manifest, and keep the existing message prefix. Closes microsoft#602.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused diagnostic change meets the stated requirements with no identified blocking issues; tests were not executed during review.
No open issues 🎉
What changed in this PR
Improves Ubuntu release-packaging diagnostics for #602, making artifact and build-input mismatches easier to distinguish.
Changes:
- Reports every mismatched field, actual and expected values, and the manifest filename while preserving the existing error prefix.
- Strengthens tests for stale artifacts, changed inputs, multiple mismatches, and missing fields.
| File | Description |
|---|---|
| scripts/test_nvx_tools.py | Adds and strengthens diagnostic assertions. |
| scripts/nvx_tools/release.py | Collects and reports detailed manifest mismatches. |
Review effort: Balanced
Contributor
|
烜 (@xuanshen666) please complete the signing. |
Contributor
|
Thank you for working on this, 烜 (@xuanshen666). We can't accept this pull request because the Contributor License Agreement wasn't signed, so I'm closing it. #664 fixes #602 with a separate implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #602.
Problem
scripts/nvx.py packagechecked five fields in each Ubuntu artifact manifest, but raised the sameUbuntu artifact manifest does not match <artifact>message for any of them. That hid whether the artifact digest or the build-input digest differed, which slowed down triage of the WindowsPackage releasefailure behind #599.Change
In
_guest_release_inputs, compare each field against its expected value and report every mismatch:missing,Ubuntu artifact manifest does not match <artifact>prefix so log searches and existing tests still match.Tests
test_guest_release_inputs_reject_stale_ubuntu_artifactsto assert the message namesartifact_sha256and notinput_sha256.test_guest_release_inputs_reject_stale_ubuntu_source_inputsto assert the message namesinput_sha256and notartifact_sha256.test_guest_release_inputs_report_multiple_mismatches_and_missing_fieldscovering two mismatching fields and a missing field.Validation
I couldn't run the suite locally (host Python is too old); the focused tests are: