Repository navigation
Document portable network device ABI - #515
Merged
Merged
Conversation
Expand the machine and device ABI specification so the portable networking contract is explicit across KVM, MSHV, and WHP. Describe the virtio-net and Consomme architecture, static dual-stack guest bootstrap, packet forwarding path, host-local access, explicit ingress forwarding, and DNS proxy behavior. Define egress rule precedence and enforcement boundaries, bounded flow and DNS state, and snapshot and restore guarantees, including state that is deliberately not serialized. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documented behavior aligns with the pinned OpenVMM implementation, including pre-listener enforcement of the 64-forward limit.
0 open findings
What changed in this PR
Documents the portable network ABI across KVM, MSHV, and WHP.
Changes:
- Defines networking architecture, addressing, forwarding, and policy enforcement.
- Documents host-local access, DNS proxying, bounded state, and snapshot behavior.
| File | Description |
|---|---|
doc/design/machine-and-device-abi.md |
Expands the portable networking contract and host/guest boundary. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pedro Henrique Penna (ppenna)
requested review from
Enrique Saurez (esaurez) and
Íñigo Goiri (goiri)
October 12, 2026 19:20
Íñigo Goiri (goiri)
approved these changes
Oct 12, 2026
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes the portable networking contract and host/guest boundary explicit across KVM, MSHV, and WHP.
Validation
git diff --cached --check(before commit)