Repository navigation
Update OpenVMM to validate time-adjusted restores - #136
Merged
Merged
Conversation
Advance the OpenVMM pin from 0bc357b to 89caf8c. The new revision validates x86_64 time-adjusted snapshot restores before performing frequency checks or restoring VM state. It rejects snapshots that lack a serialized partition unit, preventing TSC and clock adjustments from being applied to incomplete state. Restores without time adjustment remain compatible with snapshots that omit partition state. The revision also adds coverage for valid partition payloads, missing payloads, unadjusted restores, and inventory-only partition entries.
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The change affects VM restore-time clock correctness, while the pinned upstream revision remains unmerged with exact-head checks still running.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the OpenVMM submodule from 0bc357b to upstream PR #83’s exact head, 89caf8c, tightening x86_64 snapshot-restore validation.
Changes:
- Requires serialized partition state for time-adjusted restores.
- Preserves sparse restores without time adjustment and adds focused edge-case tests.
| File | Description |
|---|---|
openvmm |
Advances the gitlink to the OpenVMM validation change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pedro Henrique Penna (ppenna)
marked this pull request as ready for review
September 20, 2026 17:25
This was referenced Sep 20, 2026
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0bc357bto89caf8cWhy
Time-adjusted restores advance partition-owned clock state, including the restored vCPU TSC. Requiring the partition payload prevents clock adjustments from being applied to incomplete snapshot state.
Upstream