Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return value of GetTargetPath target #574

Merged
merged 1 commit into from Nov 5, 2015
Merged

Fix return value of GetTargetPath target #574

merged 1 commit into from Nov 5, 2015

Conversation

ghost
Copy link

@ghost ghost commented Oct 30, 2015

The implementation of Microsoft.NodejsTools.targets has a bug in it that prevents the Node.js project type from being referenced properly by CPS-based projects (Common Project System in VS). Symptoms include the following:

  • An additional project reference shows up programmatically when enumerating the project references of the CPS-based project. This "project reference" doesn't actually have a source project and just references the Microsoft.NodejsTools.WebRole.dll file in the Node.js project's bin folder.
  • The project reference shows up as unresolved in Solution Explorer.

The root of the issue is in the implementation of the GetTargetPath target. The items returned by that target end up having metadata for OriginalItemSpec. Having that item metadata set is what causes all the issues. The fix is to return the same set of files but without the OriginalItemSpec metadata.

@msftclas
Copy link

Hi @mthalman, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@paulvanbrenk
Copy link
Contributor

👍

mousetraps added a commit that referenced this pull request Nov 5, 2015
Fix return value of GetTargetPath target
@mousetraps mousetraps merged commit 45f81bb into microsoft:master Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants