Fix return value of GetTargetPath target #574
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of Microsoft.NodejsTools.targets has a bug in it that prevents the Node.js project type from being referenced properly by CPS-based projects (Common Project System in VS). Symptoms include the following:
The root of the issue is in the implementation of the GetTargetPath target. The items returned by that target end up having metadata for OriginalItemSpec. Having that item metadata set is what causes all the issues. The fix is to return the same set of files but without the OriginalItemSpec metadata.