#530 Fix MEF errors on Jade files #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,7 +38,7 @@ internal sealed class JadeClassifierProvider : IClassifierProvider { | |||
| ITextBufferFactoryService bufferFact, | |||
| IContentTypeRegistryService contentTypeService, | |||
| [ImportMany(typeof(ITaggerProvider))]Lazy<ITaggerProvider, TaggerProviderMetadata>[] taggerProviders, | |||
| [ImportMany(typeof(IClassifierProvider))]Lazy<IClassifierProvider, ClassifierProviderMetadata>[] classifierProviders) { | |||
| [ImportMany(typeof(IClassifierProvider))]Lazy<IClassifierProvider, IContentTypeMetadata>[] classifierProviders) { | |||
There was a problem hiding this comment.
nit: how about IClassifierProviderMetadata to keep the naming consistent?
|
left a minor comment, but 👍 |
billti
added a commit
that referenced
this pull request
Oct 30, 2015
#530 Fix MEF errors on Jade files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #530. Not sure what changed in Update1, but apparently this is the MEF pattern to follow, and most importantly - it works. (At least in VS2015 Update1. Still to validate on earlier builds, but this is a common pattern for a while).