fix: allow types to be used on other platforms #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
force-pushed
the
rzhao271/wintypes
branch
from
bad24fb to
eac8d95
Compare
deepak1556
reviewed
May 5, 2023
Contributor
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
Generally good with this, left minor notes. But will defer to a review from @joaomoreno
rzhao271
changed the title
joaomoreno
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds types to the module, and makes the module installable on all platforms for access to the types in a cross-platform-development context. However, attempting to call into any of the functions on a non-Windows platform will result in an exception being thrown.
This PR is a test run for windows-process-tree. Windows-process-tree is a much larger module and it'll take longer to convert it in a similar way.