Skip to content

chore: onboard onto unified pipeline #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deepak1556 merged 10 commits into from
Mar 6, 2023
Merged

chore: onboard onto unified pipeline #13

deepak1556 merged 10 commits into from
Mar 6, 2023

Conversation

@rzhao271
Copy link
Collaborator

@rzhao271 rzhao271 commented Feb 3, 2023 •
edited
Loading

@rzhao271 rzhao271 requested a review from deepak1556 February 3, 2023 19:32
@rzhao271 rzhao271 self-assigned this Feb 3, 2023
@rzhao271 rzhao271 requested a review from lszomoru February 3, 2023 20:56
@rzhao271
Copy link
Collaborator Author

rzhao271 commented Feb 3, 2023

I noticed CI wasn't running on here, so I added a GitHub Action. Let me know if I should be using Azure DevOps for CI as well.

@rzhao271 rzhao271 changed the title chore: update CI version chore: onboard onto unified pipeline Feb 3, 2023
deepak1556
deepak1556 requested changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please use Azure pipelines for the PR runs as well.

deepak1556
deepak1556 reviewed Feb 14, 2023
View reviewed changes
@rzhao271 rzhao271 requested a review from deepak1556 February 14, 2023 01:17
deepak1556
deepak1556 previously approved these changes Feb 14, 2023
View reviewed changes
@deepak1556
Copy link
Contributor

deepak1556 commented Feb 14, 2023

Oh looks like the pipelines haven't been triggered.

@rzhao271
Copy link
Collaborator Author

rzhao271 commented Mar 2, 2023 •
edited
Loading

When I tried creating a new pipeline for this repo in Azure DevOps, I was prompted to select the azure-pipelines.yml file. I think this change might need to be merged into the main branch before Azure DevOps can set up the pipeline on its end.

Here is the pipeline for the main branch file for reference, but this PR is getting rid of that file so it shouldn't be run.

@deepak1556
Copy link
Contributor

deepak1556 commented Mar 6, 2023

You can trigger a run from the branch based on the new pipeline path, triggered at https://dev.azure.com/monacotools/Monaco/_build/results?buildId=205459&view=results

@deepak1556 deepak1556 merged commit 9927257 into main Mar 6, 2023
@deepak1556 deepak1556 deleted the rzhao271/update-ci branch March 6, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@lszomoru lszomoru Awaiting requested review from lszomoru

Assignees

@rzhao271 rzhao271

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rzhao271 @deepak1556