Fix linux arm compiling and add CI for cross-compiled builds#857
Merged
deepak1556 merged 4 commits intomicrosoft:mainfrom Jan 6, 2026
Merged
Fix linux arm compiling and add CI for cross-compiled builds#857deepak1556 merged 4 commits intomicrosoft:mainfrom
deepak1556 merged 4 commits intomicrosoft:mainfrom
Conversation
rzhao271
reviewed
Jan 5, 2026
| ./scripts/linux/verify-glibc-requirements.sh | ||
|
|
||
| - name: Test | ||
| if: ${{ !matrix.cross }} |
Contributor
There was a problem hiding this comment.
Could testing and linting be re-enabled in this case, or would it be redundant?
Everything else LGTM.
Contributor
Author
There was a problem hiding this comment.
linting would be redundant (already is redundant to lint on each OS)
testing wouldn't work since it's cross-compiling. I think in order to test it would either need to be done in a container or with emulation. Or if there were linux-arm, windows-arm, and macos-x64 runners available that would be easiest
Contributor
There was a problem hiding this comment.
GitHub Actions has Linux ARM and macOS x64 runners (but not Windows ARM):
- macos-15-intel
- ubuntu-22.04-arm and ubuntu-24.04-arm
Contributor
Author
There was a problem hiding this comment.
Followed up on this using all native runners instead of cross-compiling: #865
deepak1556
approved these changes
Jan 6, 2026
dmitrivMS
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the cross-compilation for linux arm builds to correctly use the sysroot and adds CI for cross-compiling.
The added CI caught an issue that the cross-compiled build was not correctly using the sysroot and linking against the wrong GLIBC version. Installing the correct cross-compilation toolchain fixes that.
Also fixes a duplicate trailing slash here:
node-pty/src/utils.ts
Line 20 in 772905e
Used here:
node-pty/src/unixTerminal.ts
Line 17 in 772905e