enable compiling against node 8 #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deepak1556 any harm in adding this? |
deepak1556
requested changes
May 28, 2019
Tyriar
reviewed
May 28, 2019
deepak1556
reviewed
May 28, 2019
deepak1556
approved these changes
May 28, 2019
Tyriar
approved these changes
May 28, 2019
Tyriar
added a commit
to microsoft/vscode
that referenced
this pull request
Jun 3, 2019
Includes: - microsoft/node-pty#313 Update xterm in example - microsoft/node-pty#314 Fix 32-bit Windows ConPTY crash - microsoft/node-pty#315 Fix node 8 compiling Part of #74640
Closed
This was referenced Mar 15, 2020
xiaobaidadada
pushed a commit
to xiaobaidadada/node-pty-prebuilt
that referenced
this pull request
Feb 25, 2025
enable compiling against node 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267