Update to use eslint instead of tslint

.eslintignore

@@ -1 +1,2 @@
 **/*.js
+**/dist

.eslintrc

@@ -23,7 +23,6 @@
         "no-useless-escape": "off",                                 // Suppressing Error -- need to Review Later
         "no-trailing-spaces": [ "warn", { "skipBlankLines": true }],// Enabled for auto fixing
         "no-const-assign": "error",
-        "no-constant-condition": "off",
         "comma-dangle": [ "error", "never" ],                       // Enabled for auto fixing
         "security/detect-object-injection": "off",                  // Suppress Warning -- need to Review Later
         "@typescript-eslint/ban-types": "off",

CONTRIBUTING.md

@@ -17,7 +17,7 @@ contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additio
 1. Fork this repo
 2. Clone your fork locally (`git clone https://github.com/<youruser>/node-diagnostic-channel
 3. Open a terminal and move into your local copy (`cd node-diagnostic-channel`)
-* Make sure you have `tsc`, `tslint`, `gulp`, `mocha`, and `docker` installed globally.
+* Make sure you have `tsc`, `gulp`, `mocha`, and `docker` installed globally.
 4. Run `gulp init` to install dependencies in every subdirectory, and 
 `docker-compose up -d; gulp test; docker-compose down` to run the test suites. Docker
 is useful to run the databases and other external services that are required by the

src/diagnostic-channel-publishers/package.json

@@ -5,7 +5,7 @@
   "types": "dist/src/index.d.ts",
   "scripts": {
     "build": "tsc && node copyTestAssets.js",
-    "lint": "tslint -c tslint.json -p tsconfig.json",
+    "lint": "eslint ./ --fix",
     "clean": "rimraf ./dist",
     "test": "mocha ./dist/tests/{*.js,**/*.js}",
     "debug": "mocha --inspect-brk ./dist/tests/{*.js,**/*.js}"
@@ -38,7 +38,6 @@
     "rimraf": "^2.6.1",
     "sinon": "1.17.6",
     "tedious": "^8.0.1",
-    "tslint": "^5.0.0",
     "typescript": "4.1.2",
     "winston": "^3.2.1",
     "zone.js": "^0.8.5"

src/diagnostic-channel-publishers/src/azure-coretracing.pub.ts

@@ -89,7 +89,7 @@ const azureCoreTracingPatchFunction: PatchFunction = (coreTracing: typeof coreTr
             const azureSdkInstr = require("@azure/opentelemetry-instrumentation-azure-sdk") as typeof azureSdkInstrTypes;
             openTelemetryInstr.registerInstrumentations({
                 instrumentations: [
-                    azureSdkInstr.createAzureSdkInstrumentation()
+                    azureSdkInstr.createAzureSdkInstrumentation() as any
                 ]
             });
         }

src/diagnostic-channel-publishers/tests/util/mongodbcore-mock-replay.ts

@@ -39,14 +39,13 @@ export const makeMongodbcoreConnectionReplayPatchFunction: (mongoCommunication:
             const next = mongoCommunication.shift();
             if (next.send) {
                 const expected = new Buffer(next.send);
-                if (true || expected.compare(buffer) === 0) {
-                    if (mongoCommunication[0].recv) {
-                        const data = new Buffer(mongoCommunication.shift().recv);
-                        setTimeout(() => {
-                            this.connection.emit("data", data);
-                        }, 0);
-                    }
-                }/*
+                if (mongoCommunication[0].recv) {
+                    const data = new Buffer(mongoCommunication.shift().recv);
+                    setTimeout(() => {
+                        this.connection.emit("data", data);
+                    }, 0);
+                }
+                /*
                 // TODO: add additional validation that the test doesn't get broken by changes in mongo's communication approach?
                 else {
                     console.log(expected.toString());

src/diagnostic-channel/package.json

@@ -5,7 +5,7 @@
   "types": "./dist/src/channel.d.ts",
   "scripts": {
     "build": "tsc",
-    "lint": "tslint -c tslint.json -p tsconfig.json",
+    "lint": "eslint ./ --fix",
     "clean": "rimraf ./dist",
     "test": "mocha ./dist/tests/**/*.js",
     "debug": "mocha --inspect-brk ./dist/tests/**/*.js"
@@ -28,7 +28,6 @@
     "mocha": "^3.2.0",
     "rimraf": "^2.6.1",
     "sinon": "1.17.6",
-    "tslint": "^5.0.0",
     "typescript": "4.1.2"
   },
   "files": [
@@ -39,4 +38,4 @@
     "package.json"
   ],
   "license": "MIT"
-}
+}

src/publisher-legacy-tests/mongo3.2.7/package.json

@@ -1,7 +1,7 @@
 {
   "scripts": {
     "build": "tsc",
-    "lint": "tslint -c tslint.json -p tsconfig.json",
+    "lint": "eslint ./ --fix",
     "clean": "rimraf ./dist",
     "test": "mocha --recursive ./dist/{*.js,**/*.js}",
     "debug": "mocha --inspect-brk ./dist/tests/{*.js,**/*.js}"
@@ -23,7 +23,6 @@
     "mongodb": "3.2.7",
     "q": "1.5.0",
     "rimraf": "^2.6.1",
-    "tslint": "^5.0.0",
     "typescript": "4.1.2",
     "zone.js": "^0.8.5"
   },
@@ -38,4 +37,4 @@
     "package.json"
   ],
   "license": "MIT"
-}
+}

src/publisher-legacy-tests/pg6/package.json

@@ -1,7 +1,7 @@
 {
   "scripts": {
     "build": "tsc",
-    "lint": "tslint -c tslint.json -p tsconfig.json",
+    "lint": "eslint ./ --fix",
     "clean": "rimraf ./dist",
     "test": "mocha --recursive ./dist/{*.js,**/*.js}",
     "debug": "mocha --inspect-brk ./dist/tests/{*.js,**/*.js}"
@@ -24,7 +24,6 @@
     "pg": "^6.4.1",
     "q": "1.5.0",
     "rimraf": "^2.6.1",
-    "tslint": "^5.0.0",
     "typescript": "4.1.2",
     "zone.js": "^0.8.5"
   },

src/publisher-legacy-tests/winston2/package.json

@@ -1,7 +1,7 @@
 {
   "scripts": {
     "build": "tsc",
-    "lint": "tslint -c tslint.json -p tsconfig.json",
+    "lint": "eslint ./ --fix",
     "clean": "rimraf ./dist",
     "test": "mocha --recursive ./dist/{*.js,**/*.js}",
     "debug": "mocha --inspect-brk ./dist/tests/{*.js,**/*.js}"
@@ -22,7 +22,6 @@
     "mocha": "^3.2.0",
     "q": "1.5.0",
     "rimraf": "^2.6.1",
-    "tslint": "^5.0.0",
     "typescript": "4.1.2",
     "winston": "^2.3.1",
     "zone.js": "^0.8.5"
@@ -38,4 +37,4 @@
     "package.json"
   ],
   "license": "MIT"
-}
+}

src/subs/bunyan-sub/package.json

@@ -4,14 +4,13 @@
     "main": "bunyan.sub.js",
     "scripts": {
         "build": "tsc",
-        "lint": "tslint -c tslint.json -p tsconfig.json"
+        "lint": "eslint ./ --fix"
     },
     "devDependencies": {
         "applicationinsights": ">= 0.19.0",
         "diagnostic-channel": "../../diagnostic-channel",
         "diagnostic-channel-publishers": "../../diagnostic-channel-publishers",
         "mocha": "^3.2.0",
-        "tslint": "^5.0.0",
         "typescript": "4.1.2"
     },
     "peerDependencies": {

src/subs/console-sub/package.json

@@ -4,14 +4,13 @@
     "main": "console.sub.js",
     "scripts": {
         "build": "tsc",
-        "lint": "tslint -c tslint.json -p tsconfig.json"
+        "lint": "eslint ./ --fix"
     },
     "devDependencies": {
         "applicationinsights": ">= 0.19.0",
         "diagnostic-channel": "../../diagnostic-channel",
         "diagnostic-channel-publishers": "../../diagnostic-channel-publishers",
         "mocha": "^3.2.0",
-        "tslint": "^5.0.0",
         "typescript": "4.1.2"
     },
     "peerDependencies": {

src/subs/mongodb-sub/package.json

@@ -4,14 +4,13 @@
     "main": "mongodb.sub.js",
     "scripts": {
         "build": "tsc",
-        "lint": "tslint -c tslint.json -p tsconfig.json"
+        "lint": "eslint ./ --fix"
     },
     "devDependencies": {
         "applicationinsights": ">= 0.19.0",
         "diagnostic-channel": "../../diagnostic-channel",
         "diagnostic-channel-publishers": "../../diagnostic-channel-publishers",
         "mocha": "^3.2.0",
-        "tslint": "^5.0.0",
         "typescript": "4.1.2"
     },
     "peerDependencies": {

src/subs/mysql-sub/package.json

@@ -4,14 +4,13 @@
     "main": "mysql.sub.js",
     "scripts": {
         "build": "tsc",
-        "lint": "tslint -c tslint.json -p tsconfig.json"
+        "lint": "eslint ./ --fix"
     },
     "devDependencies": {
         "applicationinsights": ">= 0.19.0",
         "diagnostic-channel": "../../diagnostic-channel",
         "diagnostic-channel-publishers": "../../diagnostic-channel-publishers",
         "mocha": "^3.2.0",
-        "tslint": "^5.0.0",
         "typescript": "4.1.2"
     },
     "peerDependencies": {

src/subs/redis-sub/package.json

@@ -4,14 +4,13 @@
     "main": "redis.sub.js",
     "scripts": {
         "build": "tsc",
-        "lint": "tslint -c tslint.json -p tsconfig.json"
+        "lint": "eslint ./ --fix"
     },
     "devDependencies": {
         "applicationinsights": ">= 0.19.0",
         "diagnostic-channel": "../../diagnostic-channel",
         "diagnostic-channel-publishers": "../../diagnostic-channel-publishers",
         "mocha": "^3.2.0",
-        "tslint": "^5.0.0",
         "typescript": "4.1.2"
     },
     "peerDependencies": {