Skip to content
This repository was archived by the owner on Sep 18, 2024. It is now read-only.

Fix local IT #5544

Merged
merged 4 commits into from
May 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nni/experiment/experiment.py
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ def _stop_nni_manager(self) -> None:
if self._proc is not None:
try:
rest.delete(self.port, '/experiment', self.url_prefix)
self._proc.wait()
except Exception as e:
_logger.exception(e)
_logger.warning('Cannot gracefully stop experiment, killing NNI process...')
Expand Down
3 changes: 2 additions & 1 deletion ts/nni_manager/common/trial_keeper/keeper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,13 @@ export class TrialKeeper {

// TODO: support user configurable init command
public async start(): Promise<EnvironmentInfo> {
this.envInfo = { id: this.envId, type: 'hot' } as EnvironmentInfo;

await Promise.all([
this.scheduler.start(),
this.channels.start(),
]);

this.envInfo = { id: this.envId, type: 'hot' } as EnvironmentInfo;
Object.assign(this.envInfo, await collectPlatformInfo(this.gpuEnabled));
return this.envInfo;
}
Expand Down