Clarify the note about adding MU_CHANGE comments #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out0xb2
approved these changes
Oct 29, 2020
makubacki
reviewed
Oct 29, 2020
| EFI_STATUS | ||
| EFIAPI | ||
| SomeFunction ( | ||
| VOID |
There was a problem hiding this comment.
The indentation looks like 8 spaces instead of 2. Was that intentional?
| ) | ||
| { | ||
| EFI_STATUS Status; | ||
| // MU_CHANGE [BEGIN] - Add new counters for Feature X |
There was a problem hiding this comment.
Is the single line comment/tag still allowed? If so, it might help clarify by providing a single line example as well.
|
Apologies! My browser didn't refresh to show that there were additional comments. Will address these in another PR. |
julorenz117
pushed a commit
to julorenz117/mu
that referenced
this pull request
Aug 19, 2024
## Description Our memory protection policy is now robust enough to ensure that platforms have no read/write/execute pages before ExitBootServices. This update adds a test to the DxePagingAuditApp to check the page table for RWX pages and only exempt them if the region is part of a nonprotected image or special region. Users can still utilize the app to dump paging data to the EFI partition by calling the application with the '-d' flag. By default, the app will run the RWX test. ## Breaking change? No ## How This Was Tested Running the test on Q35 ## Integration Instructions The test will identify RWX regions. Platforms should identify these regions to determine if they must be RWX. If they really must be RWX, the platform can utilize the Memory Protection Special Region Protocol to create a special region.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra dash changes are to pass updated markdownlint.