Fix pre-commit linting failures in TI provider#870
Merged
Conversation
Co-authored-by: ianhelle <13070017+ianhelle@users.noreply.github.com>
…patibility Co-authored-by: ianhelle <13070017+ianhelle@users.noreply.github.com>
Co-authored-by: ianhelle <13070017+ianhelle@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix TI lookups using Microsoft Sentinel provider
Migrate TI provider to new ThreatIntelIndicators table schema
Jan 16, 2026
ianhelle
approved these changes
Jan 21, 2026
ianhelle
approved these changes
Jan 21, 2026
Co-authored-by: ianhelle <13070017+ianhelle@users.noreply.github.com>
…s dependency Co-authored-by: ianhelle <13070017+ianhelle@users.noreply.github.com>
Co-authored-by: ianhelle <13070017+ianhelle@users.noreply.github.com>
Copilot
AI
changed the title
Migrate TI provider to new ThreatIntelIndicators table schema
Fix pre-commit linting failures in TI provider
Jan 21, 2026
ianhelle
approved these changes
Jan 21, 2026
Contributor
|
@copilot - please suppress the bandit errors (using # nosec) in the three files indicated in the linting failures: msticpy/data/drivers/openobserve_driver.py, splunk_driver.py and security_graph_driver |
Co-authored-by: ianhelle <13070017+ianhelle@users.noreply.github.com>
Contributor
Author
Suppressed bandit B105 false positives with |
ianhelle
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-commit hooks were failing on the TI provider refactoring due to complexity warnings and missing dependencies.
Changes
Suppressed complexity warnings in
parse_resultsThreatIntelligenceIndicator+ newThreatIntelIndicatorsSTIX format)# noqa: PLR0912, PLR0915 # pylint: disable=too-many-branchesFixed
check_reqs_allpre-commit hooksetuptools>=42to.pre-commit-config.yamladditional_dependenciesModuleNotFoundError: No module named 'setuptools.config'Suppressed bandit B105 false positives
# noseccomments in three driver files to suppress false positive warnings for hardcoded passwordsmsticpy/data/drivers/openobserve_driver.py- documentation string for password parametermsticpy/data/drivers/splunk_driver.py- documentation string for password parametermsticpy/data/drivers/security_graph_driver.py- None value for client_secret initializationOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.