[nbwidgets] Querytime - Fix python 3.12 deprecation warning+ apply typing#849
Merged
ianhelle merged 16 commits intomicrosoft:mainfrom May 24, 2025
Merged
Conversation
Collaborator
FlorianBracq
commented
May 18, 2025
FlorianBracq
commented
- Update nbwidgets.query_time to set timezone info in datetime objects
- Apply typing to variables and function arguments
- Explode kwargs
Collaborator
Author
|
It doesn't look like the linting errors are related to my updates, how would you like those to be tackled? |
Adding switch for --use-pep517 to pip install (some transisitive dependencies are causing pip deprecation warnings
ianhelle
approved these changes
May 24, 2025
raj-axe
pushed a commit
to raj-axe/msticpy
that referenced
this pull request
Aug 11, 2025
…ping (microsoft#849) * Apply typing * Replace datetime.utcnow with datetime.now(timezone.utc) * Apply generic typing * Explode kwargs and complete typing * Update RegisteredWidget to include classvar * Linting fixes in current main * Fixing pylint module-length warnings Adding switch for --use-pep517 to pip install (some transisitive dependencies are causing pip deprecation warnings * Correcting mypy supression in timeseries.py --------- Co-authored-by: ianhelle <ianhelle@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.