Merged
Conversation
ianhelle
approved these changes
Feb 5, 2025
Contributor
ianhelle
left a comment
ianhelle
left a comment
There was a problem hiding this comment.
I wasn't really able to verify this against the API but it looks reasonable.
The only thing that I was unsure about was the {Instance} variable in base URL - presumably this is, like ServiceNow, where you have an instance of the API per customer or something like that?
You might want to publicize its existence by addin something to the docs\source\data_acquisition\TIProviders.rst doc - but it's up to you.
Many thanks for the submission!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This TI provider is using the Cyberint API for IoC lookup.