Merged
Conversation
Collaborator
FlorianBracq
commented
Jan 8, 2025
FlorianBracq
commented
- Apply typing for Azure Kusto Driver
- Apply ruff linting
- Explode some kwargs
- Remove some redundancy between DriverBase & AzureKustoDriver constructors
- Attribute environment (AzureKustoDriver) seems redundant with data_environment (DriverBase)
- Driver's property "MAX_THREADS" being set twice
FlorianBracq
force-pushed
the
azure-kusto-driver-typing
branch
from
41b9dc4 to
1934b2e
Compare
ianhelle
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.