Add typing hints to core classes#810
Merged
ianhelle merged 8 commits intomicrosoft:mainfrom Dec 6, 2024
Merged
Conversation
ianhelle
approved these changes
Dec 6, 2024
Contributor
ianhelle
left a comment
ianhelle
left a comment
There was a problem hiding this comment.
Awesome work battling through this gnarly code!!!
Contributor
|
CodeQL has run successfully on this PR - some problem with it reporting status correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to keep this PR small with minor code changes and close to no rewrite.
Hopefully the typing will help others!