Fixing azure_monitor_driver for deprecated httpx API#809
Merged
Conversation
httpx API call. Also fixed a doc bug in process_tree_utils and initializer in host_logon_session.
ianhelle
requested review from
FlorianBracq,
petebryan and
ryan-detect-dot-dev
ianhelle
commented
Dec 6, 2024
Contributor
Author
ianhelle
left a comment
ianhelle
left a comment
There was a problem hiding this comment.
note - respx calls in unit tests are failing due to change in new release of httpx.
If respx update release takes a while, I will fix here
Collaborator
I have noticed typing issues that were failing the pipeline too, those should be fixed now! |
FlorianBracq
approved these changes
Dec 6, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpx has deprecated/removed
proxiesparameter in API call.Replacing with
mountsin httpx.ClientAlso fixed a doc bug in process_tree_utils and initializer in host_logon_session.