Merged
Conversation
Collaborator
FlorianBracq
commented
Aug 12, 2024
- Add more typing to msticpy/context files
- Replace outdated List/Union/Tuple/Dict/Set/Optional
- Add types in function definition
- Replace namedtuple and attr classes with dataclasses
- Exploding (some) kwargs to use explicit parameters
- Replace print with logging
- Remove redundant disabled pylint messages
- Set error messages in dedicated variables
- Forcing keyword-only arguments for boolean parameters
- Replacing some hard-coded values
- check httpx return code with property "is_success" instead of comparing to 200
…pdate-tiproviders-contextproviders
…ider-and-driver-typing
…rovider-and-driver-typing
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ianhelle
approved these changes
Sep 12, 2024
Contributor
ianhelle
left a comment
There was a problem hiding this comment.
I'm exhausted looking at that - and I mostly just skimmed through. :-)
What an amazing amount of work!
I left a few comments - mostly about help/output that should be user-visible.
Contributor
|
Also, did you use some kind of tool to do all of the annotation updates? |
# Conflicts: # msticpy/context/ip_utils.py
Collaborator
Author
I'm mostly using ruff for it. It's not perfect, but it provides quite some good guidance. It's a pain to write and review (sorry for that ;)), but it does help making the code clearer and prevents some mistakes, so I would say it's worth it! |
Also some minor spacing/formatting things
…anBracq/msticpy into pr/FlorianBracq/795
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.