Merged
Conversation
Contributor
ianhelle
commented
Jul 5, 2024
ianhelle
commented
- multiple updates to sentinel_core and sentinel_utils - to correctly adhere to parameters and not default to using config workspaces, when overridden
- removed remaining references to msrestazure
- using azure.mgmt.core.tools to parse and validate resource IDs
- deprecating use of sub_id to set default subscription and set default workspace in MicrosoftSentinel
- Sentinel Incidents get_incident now returns full alert details when alerts=true
- multiple updates to sentinel_core and sentinel_utils - to correctly adhere to parameters and not default to using config workspaces, when overridden - removed remaining references to msrestazure - using azure.mgmt.core.tools to parse and validate resource IDs - deprecating use of sub_id to set default subscription and set default workspace in MicrosoftSentinel - Sentinel Incidents get_incident now returns full alert details when alerts=true
This was
linked to
issues
Jul 5, 2024
Updating requirements to avoid packages with known vulnerabilities
Collaborator
ryan-detect-dot-dev
left a comment
ryan-detect-dot-dev
left a comment
There was a problem hiding this comment.
Looks much better than before. Let's chat about this PR next we meet.
Collaborator
ryan-detect-dot-dev
left a comment
ryan-detect-dot-dev
left a comment
There was a problem hiding this comment.
LGTM! Much cleaner!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.