Add extra tests and fixes to QueryProvider, DriverBase and (as)sync query handling#777
Merged
ianhelle merged 17 commits intomicrosoft:mainfrom May 28, 2024
Merged
Add extra tests and fixes to QueryProvider, DriverBase and (as)sync query handling#777ianhelle merged 17 commits intomicrosoft:mainfrom
ianhelle merged 17 commits intomicrosoft:mainfrom
Conversation
* Updated conda reqs files for new packages * Updating version to 2.11 * Fix for missing label in RDAP data * Fix for missing 'label' item in RDAP data
…as it cannot be instanciated + remove implementation
…xec_synchronous_queries
FlorianBracq
changed the title
ianhelle
approved these changes
May 24, 2024
Contributor
ianhelle
left a comment
ianhelle
left a comment
There was a problem hiding this comment.
This is v cool indeed. Thx so much Florian.
Especially impressed with the detailed testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update code to ensure consistency and fix bugs for:
Those changes are the first steps to some rewrites of the way split queries + additional connections are handled to simplify query caching (#756) and error handling
Test coverage have been increased to 100% (according to pytest) to ensure nothing will break for future updates.