add LocalOsquery driver based on LocalData one#624
Merged
ianhelle merged 16 commits intomicrosoft:mainfrom Apr 18, 2023
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ianhelle
requested changes
Feb 9, 2023
Contributor
ianhelle
left a comment
ianhelle
left a comment
There was a problem hiding this comment.
I think this is awesome but maybe we should iterate a little over the implementation
…memory on connect/query/schema access. Changed name/enum of provider to OSQueryLogs Added template unit test case test_load_osquery_driver.py Added entry in msticpyconfig-test.yaml for OSQueryLogs (in DataProviders section)
…osquery_driver.py
Contributor
|
@juju4 I've pushed some changes to the PR. I think these make it a bit cleaner but see what you think. |
Collaborator
Author
|
On test data, will review to have a dataset available |
Collaborator
Author
|
shared some data through discord |
Auto-generate query names from data Rename columns from json-normalized form Add documentation Add unit tests and test data
ianhelle
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Known issues