-
Notifications
You must be signed in to change notification settings - Fork 7
FEAT: BCP WRAPPER C CODE #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jahnvi480
wants to merge
17
commits into
jahnvi/bcp_apis
Choose a base branch
from
jahnvi/bcp_wrapper_c
base: jahnvi/bcp_apis
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…python into jahnvi/bcp_wrapper_c
… jahnvi/bcp_wrapper_c
ADO Task ID: [AB#37623](https://sqlclientdrivers.visualstudio.com/c6d89619-62de-46a0-8b46-70b92a84d85e/_workitems/edit/37623) This pull request updates pipeline configurations to streamline triggers and improve naming conventions. The changes focus on ensuring pipelines are triggered only on relevant events and enhancing clarity in pipeline naming. Updates to pipeline triggers: * [`eng/pipelines/build-whl-pipeline.yml`](diffhunk://#diff-a871d64acfb78366b4b077045db53551c2df7d622854569f5f6780ad2ec6f911L4-L9): Modified the trigger to activate only on merges to the `main` branch, removing the `dev` branch from the trigger list. Enhancements to pipeline naming: * Renamed `eng/pipelines/test-pipeline.yml` to `eng/pipelines/pr-validation-pipeline.yml` and updated its name within the file for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the
mssql_python
package, focusing on enhancing functionality, improving type safety, and simplifying the codebase. Key changes include renaming methods for clarity, introducing new fields for column definitions, and refactoring connection and cursor management to leverage theddbc_bindings.Connection
abstraction.Bulk Copy Enhancements:
run_bcp
tosql_bulk_copy
for better clarity and updated associated logging messages. (mssql_python/bcp_main.py
)field_terminator
androw_terminator
in column definitions, allowing more flexible bulk copy operations. (mssql_python/bcp_main.py
)user_data_type
to theColumnFormat
class to support extended column metadata. (mssql_python/bcp_options.py
)Connection Refactoring:
henv
,hdbc
) withddbc_bindings.Connection
, simplifying initialization and lifecycle management. (mssql_python/connection.py
)ddbc_bindings.Connection
methods likeset_autocommit
,commit
, androllback
. (mssql_python/connection.py
)Cursor Refactoring:
alloc_statement_handle
method, streamlining resource management. (mssql_python/cursor.py
)These changes improve code readability, maintainability, and functionality, aligning the package with modern Python practices while enhancing its capabilities for database operations.