Skip to content

FEAT: BCP WRAPPER C CODE #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: jahnvi/bcp_apis
Choose a base branch
from
Open

Conversation

jahnvi480
Copy link
Contributor

This pull request introduces significant updates to the mssql_python package, focusing on enhancing functionality, improving type safety, and simplifying the codebase. Key changes include renaming methods for clarity, introducing new fields for column definitions, and refactoring connection and cursor management to leverage the ddbc_bindings.Connection abstraction.

Bulk Copy Enhancements:

  • Renamed run_bcp to sql_bulk_copy for better clarity and updated associated logging messages. (mssql_python/bcp_main.py)
  • Enhanced bulk mode handling by introducing support for field_terminator and row_terminator in column definitions, allowing more flexible bulk copy operations. (mssql_python/bcp_main.py)
  • Added a new field user_data_type to the ColumnFormat class to support extended column metadata. (mssql_python/bcp_options.py)

Connection Refactoring:

  • Replaced manual connection handle management (henv, hdbc) with ddbc_bindings.Connection, simplifying initialization and lifecycle management. (mssql_python/connection.py)
  • Removed redundant methods for connection attribute handling and replaced them with direct calls to ddbc_bindings.Connection methods like set_autocommit, commit, and rollback. (mssql_python/connection.py)

Cursor Refactoring:

  • Updated cursor initialization and statement handle allocation to rely on the connection's alloc_statement_handle method, streamlining resource management. (mssql_python/cursor.py)

These changes improve code readability, maintainability, and functionality, aligning the package with modern Python practices while enhancing its capabilities for database operations.

@jahnvi480 jahnvi480 closed this May 29, 2025
@jahnvi480 jahnvi480 reopened this May 29, 2025
@jahnvi480 jahnvi480 marked this pull request as ready for review May 29, 2025 16:51
Jahnvi Thakkar and others added 13 commits May 30, 2025 18:11
ADO Task ID:
[AB#37623](https://sqlclientdrivers.visualstudio.com/c6d89619-62de-46a0-8b46-70b92a84d85e/_workitems/edit/37623)

This pull request updates pipeline configurations to streamline triggers
and improve naming conventions. The changes focus on ensuring pipelines
are triggered only on relevant events and enhancing clarity in pipeline
naming.

Updates to pipeline triggers:

*
[`eng/pipelines/build-whl-pipeline.yml`](diffhunk://#diff-a871d64acfb78366b4b077045db53551c2df7d622854569f5f6780ad2ec6f911L4-L9):
Modified the trigger to activate only on merges to the `main` branch,
removing the `dev` branch from the trigger list.

Enhancements to pipeline naming:

* Renamed `eng/pipelines/test-pipeline.yml` to
`eng/pipelines/pr-validation-pipeline.yml` and updated its name within
the file for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants