FIX: Interactive on Windows #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes interactive authentication handling on Windows by adjusting how the auth_type is set in the process_auth_parameters function. The change ensures that interactive authentication is properly configured before checking the platform, allowing Windows to handle AADInteractive natively.
- Moves the
auth_type = "interactive"assignment to occur before the Windows platform check - Sets
auth_type = Noneon Windows to allow native AADInteractive handling instead of skipping parameter addition
Comments suppressed due to low confidence (1)
github-actions
bot
added
pr-size: small
github-actions
bot
added
pr-size: small
sumitmsft
approved these changes
Jul 18, 2025
gargsaumya
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO Work Item Reference
Summary
This pull request includes a small change to the
process_auth_parametersfunction inmssql_python/auth.py. The change adjusts how theauth_typeis handled for interactive authentication on Windows, ensuring compatibility with native handling of AADInteractive.