FEAT: Adding Default Auth for Python #134
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO Work Item Reference
Summary
This pull request refactors the
add_driver_name_to_app_parameterfunction inmssql_python/helpers.pyto improve readability, modularity, and support for additional authentication types. Key changes include consolidating authentication handling logic, introducing a unifiedauth_typevariable, and refining parameter filtering and token generation for different Azure Active Directory (AAD) authentication methods.Refactoring and code simplification:
has_aad_interactive,has_aad_device_code) with a singleauth_typevariable to track the authentication type, improving code clarity and reducing redundant logic.exclude_keys) to exclude sensitive parameters during AAD authentication.Enhanced support for AAD authentication:
ActiveDirectoryDefaultauthentication by introducing a new case in theauth_typehandling logic and usingDefaultAzureCredentialfor token generation.ActiveDirectoryDeviceCodeandActiveDirectoryInteractiveauthentication to ensure consistent handling and modularity.Other improvements:
APP=MSSQL-Pythonparameter more consistently when theAPPkey is not found. (F