-
Notifications
You must be signed in to change notification settings - Fork 27
FEAT: Azure Interactive support for Mac and Linux #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
709b6fb
6db161b
6742d99
c37a8da
52e2f72
6711a26
dc446d9
006e5b4
f5749dc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,4 +62,8 @@ def __iter__(self): | |
|
|
||
| def __repr__(self): | ||
| """Return a string representation of the row""" | ||
| return f"Row{tuple(self._values)}" | ||
| return f"Row{tuple(self._values)}" | ||
|
|
||
| def __str__(self): | ||
| """Return a string representation of the row""" | ||
| return f"Row({', '.join(map(str, self._values))})" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we wouldn't be needing Row(...) in the string representations, for end users the output should look like a tuple (e.g., (1, 2, 3)). I suggest updating both the methods as follows: this makes sure that printing or representing a Row instance makes it behave just like a tuple, which is the expected behaviour, also please add tests for this inside test cursor to test fetch functions results.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe these changes should be a separate PR of its own |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The auth logic is currently spread across multiple helpers and is resulting in cascading function changes and unstable signatures.
I recommend refactoring all authentication-related code into a dedicated mssql_python/auth.py module. This will centralize and simplify authentication logic and help maintain single responsibility in other modules (like helpers and connection).