Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add | Add support in SQLServerBulkCopy to allow Pooled/XA Connection instances during object creation. #968

Merged
merged 10 commits into from
Mar 11, 2019

Conversation

cheenamalhotra
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #968 into dev will decrease coverage by 0.1%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #968      +/-   ##
============================================
- Coverage     50.58%   50.47%   -0.11%     
+ Complexity     2915     2914       -1     
============================================
  Files           120      120              
  Lines         27987    27990       +3     
  Branches       4678     4679       +1     
============================================
- Hits          14156    14129      -27     
- Misses        11535    11568      +33     
+ Partials       2296     2293       -3
Flag Coverage Δ Complexity Δ
#JDBC42 50.04% <50%> (+0.01%) 2874 <1> (+7) ⬆️
#JDBC43 50.42% <50%> (-0.1%) 2912 <1> (-2)
Impacted Files Coverage Δ Complexity Δ
...t/sqlserver/jdbc/SQLServerConnectionPoolProxy.java 13.87% <100%> (+0.41%) 15 <1> (+1) ⬆️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.57% <33.33%> (+0.05%) 253 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-3.3%) 15% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 66.53% <0%> (-0.81%) 64% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 43.17% <0%> (-0.5%) 312% <0%> (-3%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 46.86% <0%> (-0.44%) 111% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (-0.44%) 43% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.18% <0%> (-0.36%) 0% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 53.21% <0%> (-0.2%) 216% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.58% <0%> (-0.17%) 0% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb72f76...81803af. Read the comment docs.

@cheenamalhotra
Copy link
Member Author

Jars for testing:
mssql-jdbc-PR968.zip

@cheenamalhotra cheenamalhotra added this to the 7.3.0 milestone Mar 5, 2019
lilgreenbird
lilgreenbird previously approved these changes Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants