-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add | Add support in SQLServerBulkCopy to allow Pooled/XA Connection instances during object creation. #968
Merged
cheenamalhotra
merged 10 commits into
microsoft:dev
from
cheenamalhotra:bulkCopyConnections
Mar 11, 2019
Merged
Add | Add support in SQLServerBulkCopy to allow Pooled/XA Connection instances during object creation. #968
cheenamalhotra
merged 10 commits into
microsoft:dev
from
cheenamalhotra:bulkCopyConnections
Mar 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #968 +/- ##
============================================
- Coverage 50.58% 50.47% -0.11%
+ Complexity 2915 2914 -1
============================================
Files 120 120
Lines 27987 27990 +3
Branches 4678 4679 +1
============================================
- Hits 14156 14129 -27
- Misses 11535 11568 +33
+ Partials 2296 2293 -3
Continue to review full report at Codecov.
|
Jars for testing: |
lilgreenbird
reviewed
Mar 5, 2019
src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyTimeoutTest.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Mar 5, 2019
src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyTestWrapper.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Mar 5, 2019
src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyConnectionTest.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Mar 5, 2019
src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyConnectionTest.java
Show resolved
Hide resolved
lilgreenbird
reviewed
Mar 5, 2019
ulvii
reviewed
Mar 5, 2019
src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyColumnMappingTest.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Mar 5, 2019
src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyColumnMappingTest.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Mar 6, 2019
lilgreenbird
previously approved these changes
Mar 6, 2019
lilgreenbird
approved these changes
Mar 11, 2019
ulvii
reviewed
Mar 11, 2019
ulvii
reviewed
Mar 11, 2019
ulvii
reviewed
Mar 11, 2019
ulvii
reviewed
Mar 11, 2019
ulvii
approved these changes
Mar 11, 2019
rene-ye
approved these changes
Mar 11, 2019
peterbae
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.