Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved retry logic for intermittent TLS1.2 issue #882

Merged
merged 4 commits into from
Nov 27, 2018

Conversation

ulvii
Copy link
Contributor

@ulvii ulvii commented Nov 16, 2018

Intermittent TLS1.2 issue details can be found here.

@codecov-io
Copy link

codecov-io commented Nov 16, 2018

Codecov Report

Merging #882 into dev will decrease coverage by 0.09%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##                dev     #882     +/-   ##
===========================================
- Coverage     48.74%   48.65%   -0.1%     
+ Complexity     2813     2808      -5     
===========================================
  Files           118      118             
  Lines         27863    27869      +6     
  Branches       4637     4640      +3     
===========================================
- Hits          13582    13559     -23     
- Misses        12086    12115     +29     
  Partials       2195     2195
Flag Coverage Δ Complexity Δ
#JDBC42 48.2% <28.57%> (+0.01%) 2766 <0> (+2) ⬆️
#JDBC43 48.57% <28.57%> (-0.07%) 2804 <0> (-5)
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.86% <28.57%> (-0.08%) 0 <0> (ø)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (-2.2%) 15% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.27% <0%> (-0.77%) 252% <0%> (-7%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.73% <0%> (-0.66%) 108% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.45% <0%> (-0.12%) 0% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.48% <0%> (+0.19%) 5% <0%> (+1%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 64.32% <0%> (+0.2%) 64% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (+0.21%) 43% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46a5107...a5c1684. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.3 milestone Nov 20, 2018
rene-ye
rene-ye previously approved these changes Nov 23, 2018
cheenamalhotra
cheenamalhotra previously approved these changes Nov 23, 2018
@ulvii ulvii dismissed stale reviews from cheenamalhotra and rene-ye via 81497d1 November 26, 2018 19:39
@ulvii ulvii merged commit 1fe2515 into microsoft:dev Nov 27, 2018
@ulvii ulvii deleted the Issue879 branch November 27, 2018 19:03
ulvii added a commit that referenced this pull request Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants