Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Intermittent BulkCopyResultSetCursorTest error #854

Merged
merged 8 commits into from
Nov 28, 2018

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented Oct 26, 2018

Resolves an intermittent error where rows retrieved were out of order compared to the expected.

E.G: org.opentest4j.AssertionFailedError: Expected Value:12345.12345, Actual Value: 45.12345 ==> expected: but was:

@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #854 into dev will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               dev     #854      +/-   ##
===========================================
+ Coverage     48.6%   49.04%   +0.44%     
- Complexity    2796     2828      +32     
===========================================
  Files          116      116              
  Lines        27885    27875      -10     
  Branches      4651     4650       -1     
===========================================
+ Hits         13553    13671     +118     
+ Misses       12124    12086      -38     
+ Partials      2208     2118      -90
Flag Coverage Δ Complexity Δ
#JDBC42 48.52% <ø> (+0.42%) 2780 <ø> (+29) ⬆️
#JDBC43 48.54% <ø> (+0.07%) 2795 <ø> (+4) ⬆️
Impacted Files Coverage Δ Complexity Δ
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.14% <0%> (-0.87%) 42% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 64.12% <0%> (-0.21%) 64% <0%> (ø)
...va/com/microsoft/sqlserver/jdbc/SQLServerClob.java 35.58% <0%> (ø) 12% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/KerbAuthentication.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...crosoft/sqlserver/jdbc/dns/DNSKerberosLocator.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.07% <0%> (+0.15%) 258% <0%> (-1%) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.68% <0%> (+0.22%) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.8% <0%> (+0.28%) 141% <0%> (+6%) ⬆️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.85% <0%> (+0.39%) 266% <0%> (+3%) ⬆️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 48.63% <0%> (+0.53%) 349% <0%> (+14%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bebfa...3f30a88. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.3 milestone Nov 20, 2018
@rene-ye rene-ye changed the title Intermittent BulkCopyResultSetCursorTest error Fix | Intermittent BulkCopyResultSetCursorTest error Nov 23, 2018
@rene-ye rene-ye merged commit 87e69d4 into microsoft:dev Nov 28, 2018
ulvii pushed a commit that referenced this pull request Nov 30, 2018
Adding unique ID to bulkcopycursor test and sorting tables by ASC before comparing to avoid intermittent insert/retrieve errors
ulvii added a commit that referenced this pull request Nov 30, 2018
@rene-ye rene-ye deleted the intermittentBulkCopyIssue branch October 10, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants