Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slf4j log messages with 'slf4j-nop' test dependency #841

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

cheenamalhotra
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 20, 2018

Codecov Report

Merging #841 into dev will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #841      +/-   ##
============================================
+ Coverage     48.29%   48.33%   +0.04%     
- Complexity     2781     2784       +3     
============================================
  Files           116      116              
  Lines         27877    27877              
  Branches       4651     4651              
============================================
+ Hits          13462    13474      +12     
+ Misses        12200    12185      -15     
- Partials       2215     2218       +3
Flag Coverage Δ Complexity Δ
#JDBC42 47.85% <ø> (+0.04%) 2739 <ø> (-1) ⬇️
#JDBC43 48.17% <ø> (-0.06%) 2777 <ø> (-2)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-3.3%) 15% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.99% <0%> (-0.44%) 89% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.73% <0%> (-0.04%) 255% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.51% <0%> (-0.04%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.52% <0%> (+0.18%) 263% <0%> (+2%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.34% <0%> (+0.34%) 0% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.79% <0%> (+0.64%) 43% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.29% <0%> (+1.09%) 107% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 54.41% <0%> (+1.47%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5167636...2c82a64. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.2 milestone Oct 22, 2018
@cheenamalhotra cheenamalhotra merged commit e38478a into microsoft:dev Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants