-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Bulk Copy API for batch insert to respect the timeout value #817
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #817 +/- ##
============================================
- Coverage 48.67% 48.59% -0.09%
+ Complexity 2817 2794 -23
============================================
Files 116 116
Lines 27878 27885 +7
Branches 4651 4651
============================================
- Hits 13571 13550 -21
+ Misses 12173 12126 -47
- Partials 2134 2209 +75
Continue to review full report at Codecov.
|
Please add tests, for default case and when timeout is set. |
@ulvii I wanted to write a test as well but that would be difficult. This part of the code is only accessed when the target server is Azure DW. |
Fixes issue #803
Statements can have timeouts on their query, and currently this isn't being respected by Bulk Copy API for batch insert. This PR fixes that issue.
I've tested this manually and confirmed the queryTimeout value is correctly applied to the Bulk Copy operation.