Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automatic detection of REALM in SPN needed for Cross Domain authentication. #40

Merged
merged 7 commits into from
Apr 17, 2017
Merged
16 changes: 16 additions & 0 deletions src/main/java/com/microsoft/sqlserver/jdbc/dns/DNSRecordSRV.java
Original file line number Diff line number Diff line change
Expand Up @@ -129,18 +129,34 @@ public int compareTo(DNSRecordSRV o) {
return serverName.compareTo(o.serverName);
}

/**
* Get the priority of DNS SRV record.
* @return a positive priority, where lowest values have to be considered first.
*/
public int getPriority() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering if user can benefit from this public methods. If so, can you please add the javaDocs for this and the rest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

return priority;
}

/**
* Get the weight of DNS record from 0 to 65535.
* @return The weight, hi value means higher probability of selecting the given record for a given priority.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo of high instead of hi maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

*/
public int getWeight() {
return weight;
}

/**
* IP port of record.
* @return a value from 1 to 65535.
*/
public int getPort() {
return port;
}

/**
* The DNS server name.
* @return a not null server name.
*/
public String getServerName() {
return serverName;
}
Expand Down