-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added automatic detection of REALM in SPN needed for Cross Domain authentication. #40
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8fd821b
Added automatic detection of REALM in SPN needed for Cross Domain aut…
pierresouchay d6de090
Added DNS Fallback for REALM resolution
pierresouchay 97c768a
Use Microsoft code formatter for consistent indentation
pierresouchay d6706b9
Added Javadoc
pierresouchay 0ab0394
Added MS license header
pierresouchay e1aed34
Fixed typo in Javadoc
pierresouchay 74de140
Added header to test file
pierresouchay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,18 +129,34 @@ public int compareTo(DNSRecordSRV o) { | |
return serverName.compareTo(o.serverName); | ||
} | ||
|
||
/** | ||
* Get the priority of DNS SRV record. | ||
* @return a positive priority, where lowest values have to be considered first. | ||
*/ | ||
public int getPriority() { | ||
return priority; | ||
} | ||
|
||
/** | ||
* Get the weight of DNS record from 0 to 65535. | ||
* @return The weight, hi value means higher probability of selecting the given record for a given priority. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo of high instead of hi maybe? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
*/ | ||
public int getWeight() { | ||
return weight; | ||
} | ||
|
||
/** | ||
* IP port of record. | ||
* @return a value from 1 to 65535. | ||
*/ | ||
public int getPort() { | ||
return port; | ||
} | ||
|
||
/** | ||
* The DNS server name. | ||
* @return a not null server name. | ||
*/ | ||
public String getServerName() { | ||
return serverName; | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering if user can benefit from this public methods. If so, can you please add the javaDocs for this and the rest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done