Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add order Hints for Bulk Copy operations #2472

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add order Hints for Bulk Copy operations #2472

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
442c816
Add order Hints for Bulk Copy operations (#1481)
mobilebilly Jul 7, 2024
1629062
Correct the wrong javadoc in SQLServerBulkCopy.addColumnOrderHint
mobilebilly Jul 7, 2024
8da2481
Escape the column name in the order hints with square bracket correctly
mobilebilly Jul 7, 2024
e35d099
Add overload addColumn which accept custom column name
mobilebilly Jul 7, 2024
dcead0d
Escape the Close escape character correctly in the escapeIdentifier m…
mobilebilly Jul 7, 2024
e3c765b
Add unit test cases to the column order hints enhancement
mobilebilly Jul 7, 2024
31b5d00
Merge branch 'microsoft:main' into main
mobilebilly Jul 10, 2024
e6a3005
Merge branch 'microsoft:main' into main
mobilebilly Aug 2, 2024
9b195c2
Merge branch 'microsoft:main' into main
mobilebilly Aug 24, 2024
f8827a2
Merge branch 'microsoft:main' into main
mobilebilly Aug 29, 2024
c4777de
Merge branch 'microsoft:main' into main
mobilebilly Sep 11, 2024
86e8f98
Merge branch 'microsoft:main' into main
mobilebilly Sep 24, 2024
971c2ec
Merge branch 'microsoft:main' into main
mobilebilly Sep 30, 2024
433da04
Merge branch 'microsoft:main' into main
mobilebilly Nov 9, 2024
761060b
Merge branch 'microsoft:main' into main
mobilebilly Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Escape the column name in the order hints with square bracket correctly
  • Loading branch information
@mobilebilly
mobilebilly committed Jul 7, 2024
commit 8da2481f933c9e0a6bca9780cb536fd69c69679d
4 changes: 2 additions & 2 deletions src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,9 +1619,9 @@ private String createInsertBulkCommand(TDSWriter tdsWriter) throws SQLServerExce

if (columnName.contains("]")) {
String escapedColumnName = columnName.replaceAll("]", "]]");
orderHintText.append(escapedColumnName).append(" ").append(sortOrderText).append(", ");
orderHintText.append("[").append(escapedColumnName).append("] ").append(sortOrderText).append(", ");
} else {
orderHintText.append(columnName).append(" ").append(sortOrderText).append(", ");
orderHintText.append("[").append(columnName).append("] ").append(sortOrderText).append(", ");
}
}

Expand Down