Fix AEv2 tests exclude for reqExternalSetup and cleanup #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilgreenbird
changed the title
ulvii
approved these changes
Feb 5, 2020
rene-ye
approved these changes
Feb 5, 2020
peterbae
approved these changes
Feb 5, 2020
ulvii
pushed a commit
to ulvii/mssql-jdbc
that referenced
this pull request
Mar 3, 2020
ulvii
pushed a commit
that referenced
this pull request
Mar 3, 2020
rene-ye
added a commit
that referenced
this pull request
Mar 23, 2020
* SonarQube fixes * Fix resource leak in AE * Addressing comments * throw exception if 3rd resultset is empty * updated to use junit 5 * null check * fixed typo * added connection string to error msg * add reqExternalSetup back to XA * Hide the BouncyCastle call * Make temp class non public * updated fail error string to only include enclave properties * added check for sql linux * updated linux check to be compat for all servers * add progress for multiple servers * Update gradle profile * update bouncy version * fix dependency name * add adal4j and keyvault * Add adal4j to test compile * remove static modifiers * Revert "remove static modifiers" This reverts commit e7988cc. * Update junit and add params * split test to exclude for reqExternSetup * null checks * add h2 driver * Fix AEv2 tests exclude for reqExternalSetup and cleanup (#1247) * changes for skipping * Remove untested dependencies * Revert "Remove untested dependencies" This reverts commit a292364. * Fix | Add null check for getObject() with LocalTime and LocalDate (#1250) * added all AKV tests to use reqExternalSetup tag so they will be skipped by default (#1254) * skip AKV test properly * removed enclave properties string to failed errors as enclave tests could be skipped Co-authored-by: rene-ye <rene-ye@users.noreply.github.com> Co-authored-by: lilgreenbird <v-susanh@microsoft.com> Co-authored-by: Peter Bae <v-hyba@microsoft.com>
rene-ye
added a commit
that referenced
this pull request
Apr 15, 2020
* Fix AEv2 tests exclude for reqExternalSetup and cleanup (#1247) * skip AKV test properly * removed enclave properties string to failed errors as enclave tests could be skipped * Fix | Add null check for getObject() with LocalTime and LocalDate (#1250) * added all AKV tests to use reqExternalSetup tag so they will be skipped by default (#1254) * skip AKV test properly * removed enclave properties string to failed errors as enclave tests could be skipped * Optimize callablestatement test * stop checking AE all the time, also add some tags * some changes * test * Revert "test" This reverts commit e05c67e. * Revert "some changes" This reverts commit 62d2e64. * delete everythign * add aev2 stuff * fix index out of bounds * fix errors * Remove test that doesn't belong * revert surefire plugin * fix exclude * revert table creation logic * fixes * alter * z * z * zz * temp * zzz * zzz * re-add print * address comments * Don't use pstmt * put expected values first Co-authored-by: lilgreenbird <v-susanh@microsoft.com> Co-authored-by: Peter Bae <v-hyba@microsoft.com> Co-authored-by: rene-ye <rene-ye@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.