-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance | Remove Enum.values() calls to avoid unnecessary array cloning #1065
Conversation
Hi @cogman, I created a PR with your suggestions. Would you mind testing the attached jars and let me know whether the fix resolves your issue? |
Codecov Report
@@ Coverage Diff @@
## dev #1065 +/- ##
============================================
+ Coverage 53.08% 53.16% +0.08%
- Complexity 3159 3187 +28
============================================
Files 119 119
Lines 28022 28089 +67
Branches 4688 4710 +22
============================================
+ Hits 14875 14934 +59
- Misses 10912 10918 +6
- Partials 2235 2237 +2
Continue to review full report at Codecov.
|
@ulvii Sorry for the delay, but it looks good to me. I created a quick test app to push in 1000 TVP entries 1000 times. These are the results I got 7.2.2, 1.17gb of allocations CPU utilization was also much lower throughout the second run. The following file is flight recorder results taken through my test run |
Replacing
Enum.values()
calls with static arrays. Fix for #1051