Improvement | Fix synchronization on a non-final field (#860)

microsoft · Dec 14, 2018 · 9a1c8ce · 9a1c8ce
1 parent 02467eb
commit 9a1c8ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java b/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
@@ -3271,7 +3271,7 @@ public int getTransactionIsolation() throws SQLServerException {
     }
 
     volatile SQLWarning sqlWarnings; // the SQL warnings chain
-    Object warningSynchronization = new Object();
+    private final Object warningSynchronization = new Object();
 
     // Think about returning a copy when we implement additional warnings.
     @Override

diff --git a/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSymmetricKeyCache.java b/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSymmetricKeyCache.java
@@ -51,7 +51,7 @@ public void run() {
  *
  */
 final class SQLServerSymmetricKeyCache {
-    static Object lock = new Object();
+    static final Object lock = new Object();
     private final ConcurrentHashMap<String, SQLServerSymmetricKey> cache;
     private static final SQLServerSymmetricKeyCache instance = new SQLServerSymmetricKeyCache();
     private static ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1, new ThreadFactory() {