Test and fix for unique index lost when renaming M2M field (#86) #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add absolute links in place of #NN which are no longer valid in this repo.
sparrowt
force-pushed
the
test-m2m-field-rename
branch
from
ae4458d to
d6d1e4a
Compare
This method override was added by: ESSolutions/django-mssql-backend@08c2721 meaning that it dropped (but did not re-instate) any unique index on the M2M through table, before renaming that table. However MSSQL does not seem to require this, so rather than trying to re-create the correct indexes afterwards just don't drop them unnecessarily in the first place.
sparrowt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easiest to review as separate commits:
#NNissue references in other tests which are no longer meaningful since the fork)