Skip to content

Conversation

NandanaRaol
Copy link
Contributor

This pull request introduces support for Django 5.2 and Python 3.13, alongside adding a new SQL Server-specific implementation for the JSONArray function. Key changes span updates to CI configurations, dependency declarations, and the implementation of the new database function.

Support for Django 5.2 and Python 3.13:

  • azure-pipelines.yml: Added new matrix configurations for Django 5.2 with Python versions 3.10 through 3.13 to ensure compatibility testing. [1] [2]
  • setup.py: Updated classifiers to include Django 5.2 and Python 3.13, and extended the Django dependency range to <5.3. [1] [2]
  • tox.ini: Added Django 5.2 to the envlist and defined its dependency range. [1] [2]

New SQL Server JSONArray Implementation:

  • mssql/functions.py: Introduced the sqlserver_json_array function to handle the JSONArray operation for SQL Server, including support for nested JSON structures and various data types. Registered this implementation for Django 5.2 and above. [1] [2]

@Copilot Copilot AI review requested due to automatic review settings June 11, 2025 07:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Django 5.2 and Python 3.13 while introducing a new SQL Server–specific implementation for the JSONArray function.

  • Updates tox.ini, setup.py, and Azure Pipelines configuration to include Django 5.2 and Python 3.13 testing.
  • Implements a new SQL Server function (sqlserver_json_array) to handle JSONArray operations with support for nested JSON structures and multiple data types.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tox.ini Added Django 5.2 testing environments and updated dependency declarations.
setup.py Updated classifiers and Django dependency range to support Django 5.2.
mssql/functions.py Introduced SQL Server JSONArray implementation and registered it for Django 5.2.
azure-pipelines.yml Updated build matrix to run tests against Django 5.2 with various Python versions.
Comments suppressed due to low confidence (1)

mssql/functions.py:235

  • [nitpick] Consider passing numeric values in their native type instead of converting them to strings, unless the intended SQL parameter type requires string conversion.
                params.append(str(val))

@NandanaRaol NandanaRaol force-pushed the jsonarray branch 2 times, most recently from 52bb9fd to ad12745 Compare June 18, 2025 04:33
@NandanaRaol NandanaRaol merged commit d5e56af into dev Jun 26, 2025
43 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants