FEAT: Support 5.1 - Handled empty order-by clause by defaulting it to SELECT NULL #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refines the
_as_sql_window
method inmssql/compiler.py
to improve clarity, ensure correctness, and enhance support for SQL window functions. Key changes include adding detailed comments, handling edge cases forORDER BY
, and improving the formatting of the final SQL statement.Enhancements to
_as_sql_window
method:order_by
compiles to an empty string by defaulting toORDER BY (SELECT NULL)
.PARTITION BY
,ORDER BY
, and frame clauses with detailed comments for better maintainability. [1] [2]