FEAT:Support 5.1-Removed Deprecated Fields #454
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the _get_check_sql method to use the new condition attribute for CheckConstraint when running on Django 5.1+ while preserving backwards compatibility.
- Introduces a version check to choose between
self.conditionand the deprecatedself.check - Adds a clarifying comment above the new branch
Comments suppressed due to low confidence (1)
mssql/functions.py:385
- Indentation of this line is inconsistent with the surrounding block and will cause a syntax error. Adjust it to align with the other statements inside the
else(use 8 spaces beforewhere).
where = query.build_where(self.check)
NandanaRaol
changed the title
NandanaRaol
changed the title
…Nandana/5.1/checkconstraint
bewithgaurav
requested changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a backward-compatible update to the
_get_check_sqlmethod inmssql/functions.pyto support a new version of the Django framework.Backward compatibility and version support:
_get_check_sqlmethod to useself.conditionwhen the Django version is 5.1 or higher, while retaining the use ofself.checkfor older versions to ensure backward compatibility. (mssql/functions.py, mssql/functions.pyR380-R384)