Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions testapp/tests/test_multiple_databases.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,14 @@
from django import VERSION
from django.core.exceptions import ValidationError
from django.db import OperationalError
from django.db.backends.sqlite3.operations import DatabaseOperations
"""
Import BaseDatabaseOperations before sqlite3.operations.DatabaseOperations because:
1. DatabaseOperations in sqlite3.operations inherits from BaseDatabaseOperations.
2. Importing the base class first avoids potential circular import issues.
3. This order ensures the base class is available for subclassing.
4. This behavior was introduced in Django 5.1 and is backward compatible with earlier versions.
"""
from django.db.backends.base.operations import BaseDatabaseOperations
from django.test import TestCase, skipUnlessDBFeature

from ..models import BinaryData, Pizza, Topping
Expand All @@ -26,8 +33,8 @@ def test_in_split_parameter_list_as_sql(self):
# Issue: https://github.com/microsoft/mssql-django/issues/92

# Mimic databases that have a limit on parameters (e.g. Oracle DB)
old_max_in_list_size = DatabaseOperations.max_in_list_size
DatabaseOperations.max_in_list_size = lambda self: 100
old_max_in_list_size = BaseDatabaseOperations.max_in_list_size
BaseDatabaseOperations.max_in_list_size = lambda self: 100

mssql_iterations = 3000
Pizza.objects.bulk_create([Pizza() for _ in range(mssql_iterations)])
Expand All @@ -43,7 +50,7 @@ def test_in_split_parameter_list_as_sql(self):
prefetch_result_sqlite = Pizza.objects.using('sqlite').prefetch_related('toppings')
self.assertEqual(len(prefetch_result_sqlite), sqlite_iterations)

DatabaseOperations.max_in_list_size = old_max_in_list_size
BaseDatabaseOperations.max_in_list_size = old_max_in_list_size

def test_binaryfield_init(self):
binary_data = b'\x00\x46\xFE'
Expand Down
1 change: 1 addition & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ envlist =
{py38, py39, py310}-django41,
{py38, py39, py310}-django42,
{py310, py311, py312}-django50
{py310, py311, py312,py313}-django51

[testenv]
allowlist_externals =
Expand Down
Loading