FEAT: Support Django 5.1 - Remove index_together usage and update CI/Test Configs #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Django 5.1 by updating dependency/version requirements, updating tests to verify index creation via Meta.indexes instead of index_together, and adding conditional logic to legacy index_together handling for compatibility.
- Updated dependency declarations (tox.ini, setup.py, classifiers) to include Django 5.1.
- Modified test assertions (test_indexes.py) to check explicit index definitions via Meta.indexes.
- Added version checks in schema generation (mssql/schema.py) and provided new pipeline matrices (azure-pipelines.yml) to test against Django 5.1.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tox.ini | Added Django 5.1 dependency range |
| testapp/tests/test_indexes.py | Replaced index_together based tests with checks for Meta.indexes |
| setup.py | Updated Django dependency range and classifiers |
| mssql/schema.py | Added version checks for index_together handling; updated SQL generation comments |
| azure-pipelines.yml | Extended pipeline matrix to include multiple Python versions with Django 5.1 support |
Comments suppressed due to low confidence (1)
azure-pipelines.yml:27
- [nitpick] Consider standardizing the matrix naming (e.g. without spaces) to ensure compatibility with downstream processing if these keys are referenced programmatically.
Python3.13 - Django 5.1:
bewithgaurav
approved these changes
Jun 4, 2025
NandanaRaol
changed the title
bewithgaurav
reviewed
Jun 5, 2025
bewithgaurav
reviewed
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for Django 5.1, updates compatibility checks for removed
index_together, and adjusts testing and dependency configurations accordingly.Document link: TASK1 Removing Dependency On Index_together().loop
Ado link: https://sqlclientdrivers.visualstudio.com/mssql-django/_workitems/edit/37632