Skip to content

Fix schema db default test #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix schema db default test #305

merged 1 commit into from
Oct 18, 2023

Conversation

dauinsight
Copy link
Contributor

Fix schema.tests.SchemaTests.test_rename_keep_db_default introduced in Django 5.0

Django does not expect parentheses surrounding default values in SQL Server.

See here - https://stackoverflow.com/questions/2911953/sql-server-default-values-why-with-one-or-two-parentheses

@dauinsight dauinsight requested a review from mShan0 October 16, 2023 19:13
@dauinsight dauinsight merged commit 5c30ab6 into django50 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mShan0 mShan0 mShan0 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dauinsight @mShan0