Allow partial support for filtering against window functions #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mShan0
approved these changes
Mar 23, 2023
mShan0
added a commit
that referenced
this pull request
May 31, 2023
* Allow Django 4.2 (#227) * Allow Django 4.2 * allow Django 4.2 * Fix errors with raising FullResultSet exception and with alter_column_type_sql() and collate_sql() functions (#229) * fix error with raising fullresultset * add django4.2 condition * fix alter_column_type_sql and collate_sql to take 2 additional arguments * delete argument 'old_rel_collation' * fix arguments names * fix last_executed_query() to properly replace placeholders with params (#234) * disable allows_group_by_select_index * unskip old tests * unskip some tests * skip more tests * Use latest Django 4.2 beta for tox (#238) * use 4.2 rc1 branch (#240) * allow partial support for filtering against window functions (#239) * add subsecond support to Now() (#242) * assign value to display_size (#244) * add latest django 4.2 branch to ci * raise an error when batch_size is zero. (#259) * replicate get or create test for mssql (#265) * Add skipped tests to Django 4.2 (#268) * skip django 4.2 failing tests * skip schema test * skip aggregate annotation pruning test --------- Co-authored-by: mShan0 <mark.shan19@gmail.com> * syntax fix * ci fix * bump version to 1.3 --------- Co-authored-by: Khanh Bui <85855766+khanhmaibui@users.noreply.github.com> Co-authored-by: Khanh Bui <khanhmb815@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows partial support for filtering against window functions, which was added in Django 4.2.
Fixes the following Django 4.2 tests:
The following Django 4.2 WindowFunction test failure still remains open: