Skip to content

Fix limit_offset_sql to handle cases when there is no OFFSET #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fix limit_offset_sql to handle cases when there is no OFFSET #235

merged 1 commit into from
Mar 13, 2023

Conversation

maikhanhbui
Copy link
Contributor

@maikhanhbui maikhanhbui commented Mar 6, 2023 •
edited
Loading

This PR fixes limit_offset_sql() function to return the correct query when there is no OFFSET.

Resolves #224

@mShan0 mShan0 self-requested a review March 13, 2023 21:32
@mShan0 mShan0 merged commit 05fcbd4 into dev Mar 13, 2023
@maikhanhbui maikhanhbui deleted the limit-offset-sql-fix branch March 15, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mShan0 mShan0 mShan0 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

limit_offset_sql is returning incorrect SQL.
2 participants
@maikhanhbui @mShan0