Skip to content

Fix removing unique_together constraint if exists primary key/unique constraint on the same field. #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Fix removing unique_together constraint if exists primary key/unique constraint on the same field. #204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c43c43
Fix removing unique_together constraint if
maikhanhbui Nov 29, 2022
1070aa2
add django version requirement
maikhanhbui Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mssql/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,6 +814,14 @@ def _delete_unique_constraint_for_columns(self, model, columns, strict=False, **
model._meta.db_table, columns, unique=True, unique_constraint=False, primary_key=False,
**constraint_names_kwargs)
constraint_names = constraint_names_normal + constraint_names_index
if django_version >= (4, 1):
if constraint_names and self.connection.features.allows_multiple_constraints_on_same_fields:
# Constraint matching the unique_together name.
default_name = str(
self._unique_constraint_name(model._meta.db_table, columns, quote=False)
)
if default_name in constraint_names:
constraint_names = [default_name]
if strict and len(constraint_names) != 1:
raise ValueError("Found wrong number (%s) of unique constraints for columns %s" % (
len(constraint_names),
Expand Down