fix jsonfield test in sql server 2022 and newer #203
Merged
+14
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mShan0
added a commit
that referenced
this pull request
Dec 8, 2022
* Fixed failing timezone unit test for Django 4.1 (#169) * Added Django 4.1 tests into test suite * Fixed datetime issues * Added skipped timezone tests * fix date_trunc_sql to work with < 4-digit year set has_case_insensitive_like to True Revert "fix date_trunc_sql to work with < 4-digit year" This reverts commit 492e32c. Revert "set has_case_insensitive_like to True" This reverts commit 2bc4f8e. fix date_trunc_sql to work with < 4-digit year (#188) * set has_case_insensitive_like to True (#189) Co-Authored-By: Khanh Bui <85855766+khanhmaibui@users.noreply.github.com> Co-authored-by: Khanh Bui <85855766+khanhmaibui@users.noreply.github.com> * bump required django version to include 4.1.x updates (#192) * add introspected field type for DurationField (#191) * Add check to see if `FROM` clause exists (#190) * Make MSSQL introspection raise DatabaseError on nonexistent tables (#194) * Make MSSQL introspection raise DatabaseError on nonexistent tables * edit error message to make it specific to MSSQL * Refix JSONField has_key so it doesn't break previous Django versions (#195) * Fix removing unique_together constraint if exists primary key/unique constraint on the same field. (#204) * Fix removing unique_together constraint if exists primary key/unique constraint on the same field. * add django version requirement * fix jsonfield test in sql server 2022 and newer (#203) * fix jsonfield test in sql server 2022 * fix sql server version * fix bulk update tests (#205) * match native function updates * syntax update * fix `mssql-django` tests * trim whitespace * create custom `Window.as_sql` (#207) Co-Authored-By: Khanh Bui 85855766+khanhmaibui@users.noreply.github.com * Add skipped tests to Django 4.1 (#199) Skips the currently unfixable tests added by Django 4.1 Co-authored-by: mShan0 <mark.shan19@gmail.com> Co-authored-by: jmah8 <59151084+jmah8@users.noreply.github.com> Co-authored-by: Khanh Bui <khanhmb815@gmail.com> Co-authored-by: Khanh Bui <85855766+khanhmaibui@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix uses
JSON_PATH_EXISTSwhich was introduced in SQL Server 2022.This fixes the following test from the Django 4.1 list:
Also fixes the following tests: