Set default toolchain file only for OneBranch/container builds #3855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
approved these changes
Sep 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #3855 +/- ##
==========================================
- Coverage 86.80% 86.62% -0.18%
==========================================
Files 56 56
Lines 16693 16693
==========================================
- Hits 14490 14461 -29
- Misses 2203 2232 +29 |
wfurt
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.NET builds msquic using the same script (script/build.ps1) that we use to build the project, which does not work well with their cross-compile method where a toolchain file is not used as reported in dotnet/msquic#149.
This PR allows empty toolchain file for cross-compile. So, we only use a default toolchain file for our own OneBranch/container builds.
Testing
Needs help from @wfurt to test it.