Refactor the RX Datapath Object Abstraction Model #3826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
added
OS: Windows (User)
OS: Linux
OS: macOS
OS: Windows (Kernel)
Area: Core
Codecov Report
@@ Coverage Diff @@
## main #3826 +/- ##
=======================================
Coverage 86.57% 86.57%
=======================================
Files 56 56
Lines 16576 16581 +5
=======================================
+ Hits 14350 14355 +5
Misses 2226 2226
|
csujedihy
reviewed
Aug 22, 2023
ami-GS
reviewed
Aug 23, 2023
csujedihy
reviewed
Aug 23, 2023
mtfriesen
approved these changes
Aug 23, 2023
csujedihy
reviewed
Aug 23, 2023
| // Internal receive context. | ||
| // | ||
| typedef struct CXPLAT_DATAPATH_INTERNAL_RECV_BUFFER_CONTEXT { | ||
| typedef struct DECLSPEC_ALIGN(MEMORY_ALLOCATION_ALIGNMENT) DATAPATH_RX_PACKET { |
There was a problem hiding this comment.
If it's actually needed, we then need a comment similar to what we have in the XDP datapath.
There was a problem hiding this comment.
I'm not sure if it's strictly necessary. It was copy/paste.
There was a problem hiding this comment.
It doesn't look like it's necessary. There is no SLIST operations in this file.
I will leave it up to you.
csujedihy
approved these changes
Aug 23, 2023
csujedihy
reviewed
Aug 23, 2023
| CXPLAT_RECV_DATA Data; | ||
|
|
||
| } CXPLAT_DATAPATH_INTERNAL_RECV_BUFFER_CONTEXT; | ||
| } DATAPATH_RX_PACKET; |
There was a problem hiding this comment.
I'd add a comment saying there's a client data following the last field.
There was a problem hiding this comment.
There is already a comment at the end of CXPLAT_RECV_DATA to that effect. I'm going to leave that as is for now.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up a few things:
Testing
Existing automation
Documentation
N/A